Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lost-masonry-column does not support no unit on a "0 gutter" #383

Closed
peterramsing opened this issue Jul 1, 2017 · 0 comments
Closed

lost-masonry-column does not support no unit on a "0 gutter" #383

peterramsing opened this issue Jul 1, 2017 · 0 comments
Assignees
@peterramsing
Labels
component: lost-masonry-column resolution: Pull Request type: Bug

Comments

@peterramsing
Copy link
Owner

Is this a feature request or a bug report?
Bug Report

What is the current behavior?
lost-masonry-column does not support a unitless zero gutter

If it's a bug please provide the steps to reproduce it and maybe some code samples.

.div {
  lost-masonry-column: 60px; 
  lost-masonry-column-gutter: 0;
}

Error: TypeError: Cannot read property 'join' of null

What is the desired behavior?
Supporting unitless zero gutters.

What version of LostGrid, browser and browser version are affected by this issue? Did this happen in previous versions?
8.0.0

Anything else?
Failing tests: https://travis-ci.org/peterramsing/lost/jobs/249156939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterramsing peterramsing

Labels
component: lost-masonry-column resolution: Pull Request type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterramsing