Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the tool test skip entries from TravisCI era #152

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

peterjc
Copy link
Owner

@peterjc peterjc commented Dec 6, 2022

e.g. We can't test ncbi_deltablast_wrapper.xml without downloading a large protein domain database.

This partly reverts the exclusion list changes made in #149 to move from TravisCI to GitHub Actions

e.g. We can't test ncbi_deltablast_wrapper.xml without downloading
a large protein domain database.
@peterjc peterjc merged commit 940f223 into master Dec 6, 2022
@peterjc peterjc deleted the restore_tt_skip branch December 6, 2022 14:24
@bernt-matthias
Copy link
Contributor

I think we can only list folders in this file .. not sure. If I'm right the solution would be to comment/remove the tests for now.

@peterjc
Copy link
Owner Author

peterjc commented Dec 6, 2022

Possibly related, I was wondering why this PR seemed to skip all the tool tests...

Update: Ah, see #153

@peterjc
Copy link
Owner Author

peterjc commented Dec 6, 2022

I assumed (not having looked at this for years), that .tt_skip was handled via planemo and if it used to accept filenames it would still.

@bernt-matthias
Copy link
Contributor

Maybe I'm wrong. Lets check the workflow runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants