Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inproper log of importing #203

Merged
merged 1 commit into from
Feb 10, 2024
Merged

fix inproper log of importing #203

merged 1 commit into from
Feb 10, 2024

Conversation

peter-wangxu
Copy link
Owner

fixes GH-202

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@65c7fe9). Click here to learn what that means.

Files Patch % Lines
persistqueue/__init__.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage          ?   93.75%           
=========================================
  Files             ?       18           
  Lines             ?     2208           
  Branches          ?      230           
=========================================
  Hits              ?     2070           
  Misses            ?       88           
  Partials          ?       50           
Flag Coverage Δ
python 93.75% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-wangxu peter-wangxu merged commit 74f464a into master Feb 10, 2024
16 checks passed
@peter-wangxu peter-wangxu deleted the fix_inproper_log branch February 10, 2024 09:37
@epicwhale
Copy link

@peter-wangxu hey thanks for looking into this. I was wondering what the proposed fix accomplishes? For users who simply use say the SQLiteQueue and never install the extras, it will still always emit a redundant log each time "INFO:persistqueue:DBUtils may not be installed, install via 'pip install persist-queue[extra]'".

Would a more useful solution be to not import any MySQLQueues' in init.py unless the user explicitly loads that module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants