Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Healthcheck.Persistence degraded support #284

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add Healthcheck.Persistence degraded support #284

merged 1 commit into from
Jul 15, 2024

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Add a threshold where Healthcheck.Persistence will switch from healthy, to degraded, and finally to unhealthy.

Aaronontheweb
Aaronontheweb approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Akka.HealthCheck.Persistence.Tests/ProbeFailureSpec.cs
@@ -79,5 +79,37 @@ private PersistenceLivenessStatus PerformProbe()

return status;
}

[Fact(DisplayName = "Failures should progressively change from healthy to degraded to unhealthy")]
public async Task FailStatusProgressionTest()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit f8a4c1c into petabridge:dev Jul 15, 2024
6 checks passed
@Arkatufus Arkatufus mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb