New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Sharing `repeat` iteration as `dataset` variable #975

Merged

nunomaduro merged 3 commits into pestphp:3.x from Katalam:repeat

Jan 25, 2024

Katalam commented Oct 5, 2023 •

edited

Loading

What:

Bug Fix
New Feature
Improvement

Description:

Essentially, what was previously in Issue #908 requested
When no dataset is provided, but the repetitions are above 1, the current iteration should be passed to the closure of the test

Related:


          feat: add repeat iteration as function argument if no extra dataset i…

3ee5c29

…s provided

devajmeireles changed the title ~~Repeat Method will get the current iteration passed if no extra dataset is provided~~ [2.x] Sharing repeat iteration as dataset variable

devajmeireles approved these changes

View reviewed changes

Member

devajmeireles commented Oct 6, 2023

Hey, @Katalam ! Thanks for your PR.

Everything works as expected. Approved. 👍🏻

devajmeireles requested a review from nunomaduro

October 6, 2023 00:17

utsavsomaiya reviewed

View reviewed changes

tests/Features/Repeat.php Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

Katalam added 2 commits

October 6, 2023 15:07


          fix: add repeat iteration as the last argument when combined with dat…

ecff90d

…aset


          chore: add docs

67e452e

devajmeireles approved these changes

View reviewed changes

nunomaduro changed the base branch from 2.x to 3.x

January 25, 2024 15:01

nunomaduro changed the title ~~[2.x] Sharing repeat iteration as dataset variable~~ [3.x] Sharing repeat iteration as dataset variable

nunomaduro merged commit 815ae3c into pestphp:3.x

20 checks passed

Katalam deleted the repeat branch

January 25, 2024 15:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet