Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Print only files below the min coverage #919

Merged
merged 1 commit into from
Dec 17, 2023
Merged

[2.x] Print only files below the min coverage #919

merged 1 commit into from
Dec 17, 2023

Conversation

WendellAdriel
Copy link
Contributor

What:

  • Bug Fix
  • New Feature

Description:

This PR is adding a new --errors-only flag that when passed to the command call will print only the files that have coverage below the value set in with the --min argument

@WendellAdriel WendellAdriel mentioned this pull request Aug 18, 2023
Closed
@WendellAdriel
Copy link
Contributor Author

@devajmeireles here's the PR with the code in sync with the 2.x branch.
Follow-up of the PR #877

@nunomaduro nunomaduro merged commit 1e2ca40 into pestphp:2.x Dec 17, 2023
nunomaduro added a commit that referenced this pull request Dec 17, 2023
@nunomaduro
Revert "Merge pull request #919 from WendellAdriel/feature/coverage-e…
8f738f5 
…rrors-only-flag-2"

This reverts commit 1e2ca40, reversing
changes made to 4522cb5.
@nunomaduro
Copy link
Member

Had to revert this pull request. Seems that, if no --min is specified, no coverage of files is displayed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devajmeireles devajmeireles devajmeireles approved these changes

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
enhancement review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WendellAdriel @nunomaduro @devajmeireles