Fix an issue where a describe block will prevent a beforeEach call from executing #1294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
This PR fixes an issue where a describe block will prevent a parent describe block or a before each call from applying. This is due to the describing string being statically stored and set to null in the destructor. For example
The this example, the before each call will execute for
test1
but not fortest2
. Also, the parent describe is not applied totest2
. The following is the test output before and after this changeBefore
After