Fix NodeScopeResolver parameters #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @faissaloux Your PR works fine for v1.10.42 but the current version v.1.10.43 requires already one parameter more. 😓 Maybe you can update your PR to fix this issue too. The only thing required is an additional |
|
This PR can be closed in favour of #17 |
|
I have fixed it on this same PR. There is no need for another one. Thanks for updating me! |
faissaloux
changed the title
|
Thanks! Sandro extended this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpstan/phpstan-src
v1.10.42have added a new argument of typeSignatureMapProvidertoNodeScopeResolverwhich causing this error when installingpestphp/pest-plugin-type-coverage. Same thing for fourth last parameter which been added onv1.10.43. This must be fixed after merging this PR.