Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Should-Throw/Should -Throw to handle expected message with escaped wildcard #2559

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Aug 23, 2024

PR Summary

This target v6. This resolves #2558 so that when the expected message containing escaped wildcard is output is removes the escaped character so it shows the correct expected message that differ from the actual value.

Fix #2558

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@johlju johlju changed the title Fix Should-Throw/Should -Throw to handle expected message with escaped wildcard Fix Should-Throw/Should -Throw to handle expected message with escaped wildcard (backport) Aug 23, 2024
@johlju johlju changed the title Fix Should-Throw/Should -Throw to handle expected message with escaped wildcard (backport) Fix Should-Throw/Should -Throw to handle expected message with escaped wildcard Aug 23, 2024
@johlju
Copy link
Contributor Author

johlju commented Aug 23, 2024

@fflaten this passes the tests now. It seemed that fomatOnSave was on in this repos .vscode file so it has formated some lines without me asking it. 🙂

@nohwnd nohwnd merged commit 577a963 into pester:main Oct 1, 2024
11 checks passed
@johlju johlju deleted the fix/wildcard-escaping-in-message branch October 1, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should-Throw (and Should -Throw): Backtick is kept in error message when escaping wildcard characters
2 participants