Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace New-Object calls with ::new() #2469

Merged
merged 6 commits into from
May 20, 2024
Merged

Replace New-Object calls with ::new() #2469

merged 6 commits into from
May 20, 2024

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented May 18, 2024

PR Summary

Replaces $SafeCommands['New-Object'] calls with ::new() for improved readability and minor perf. Also removes a helper method in Pester.Factory that's no longer needed.

Leaving similar change in tests for a future PR to make sure any failures are actually code's fault.

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd nohwnd merged commit 1a3cad0 into pester:main May 20, 2024
11 checks passed
@nohwnd nohwnd added this to the 6.0.0 milestone May 20, 2024
@fflaten fflaten deleted the newobject branch May 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants