Skip blocks without runnable tests #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
changed the title
fflaten
force-pushed
the
block-skip-if-useless
branch
from
ae1e60e
to
7a5148e
Compare
Caused wrong Result as Skipped takes precedence over NotRun
fflaten
commented
May 10, 2024
3 tasks
|
Ready for review, but merge pending updated base branch for v6 |
|
@nohwnd Target this for 5.6.0 instead or wait? I'm fine with both, but shouldn't be a breaking change. |
nohwnd
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Mark blocks (incl. container root) as Skip when no child tests will run. This is done to avoid running
BeforeAll/AfterAllwhen it's not needed.Fix #2439
Fix #2449
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.