Fix false errors and broken CI-logs from P-tests #2345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
After switching to
-EncodedCommand
for childpowershell/pwsh
processes in P-tests (#2267) we get CliXML-output in CI logs and false errors in CI-report.Using
-EncodedCommand
changes default output to XML in non-interactive environments with redirected output like our AzDO Pipelines CI. The normal workaround of explicitly setting-OutputFormat Text
is not honored prior to PS 6.2 (incl. 5.1).This PR reverts to using
-Command
with different commands to handle the changed argument-behavior in PS 7.3+. It also extracts the helper to aPTestHelpers
module to reduce duplicated code.Fix #2340
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.