Start interactive execution from BeforeDiscovery #2217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Extends interactive execution to also being triggered from root-level
BeforeDiscovery
.This is necessary to avoid leaking variables from a
BeforeDiscovery
-block to Run-phase during interactive execution whenBeforeDiscovery
is placed beforeContext\Describe
which it usually is. The variables would've been made available in Run-phase from a parent scope.Before-/AfterEach
throw when used in root andBefore-/AfterAll
only works when in Discovery-phase, so they're not affected.Fix #2092
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.