-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IsOriginalValue() with IsModified and fix merging and casting of default option values #2201
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think having it not show up in the output was the only reason. |
Ready for review. |
IsDefaultValue seems like better name. Please put IsOriginalValue() back and mark it deprecated (with Obsolete attribute). Just to be nice about semantic versioning. |
I don't see it used in open source, but let's still be nice: https://grep.app/search?q=IsOriginalValue%28%29 |
After letting the name sink in, it could confuse someone when it's false while Default and Value are equal (but modified). 😅. Naming is hard. |
PR Summary
Only modify configuration options that have actually been changed when casting and merging configurations.
Option.IsOriginalValue()
is marked obsolete and is replaced by a newOption.IsModified
-property that enables us to fix merging of serialized PesterConfiguration.Fix #2198
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.