Skip to content

fix: setFeeManager() should only emit when there are real changes. #481

fix: setFeeManager() should only emit when there are real changes.

fix: setFeeManager() should only emit when there are real changes. #481

Triggered via push August 16, 2023 02:51
Status Success
Total duration 48m 59s
Artifacts

testing.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint: contracts/base/BlockContext.sol#L9
Avoid to make time-based decisions in your business logic
lint: contracts/base/ClearingHouseCallee.sol#L30
Function order is incorrect, external function can not go after internal function (line 26)
lint: contracts/base/OwnerPausable.sol#L17
Function order is incorrect, external function can not go after internal function (line 12)
lint: contracts/base/SafeOwnable.sol#L42
Function order is incorrect, external function can not go after internal function (line 28)
lint: contracts/base/UniswapV3CallbackBridge.sol#L40
Function order is incorrect, external view function can not go after internal function (line 34)
lint: contracts/ClearingHouse.sol#L150
Function order is incorrect, external function can not go after public function (line 96)
lint: contracts/ClearingHouse.sol#L653
Variable name must be in mixedCase
lint: contracts/ClearingHouse.sol#L656
Variable name must be in mixedCase
lint: contracts/DelegateApproval.sol#L105
Function order is incorrect, external view function can not go after external pure function (line 100)
lint: contracts/Exchange.sol#L229
Code contains empty blocks
Foundry Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
contract-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/