Merge pull request #106 from perpetual-protocol/chore/update-code-owners #505
CheshireCatNickAnnotations
16 warnings
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
contracts/base/BlockContext.sol#L9
Avoid to make time-based decisions in your business logic
|
|
lint:
contracts/base/ClearingHouseCallee.sol#L30
Function order is incorrect, external function can not go after internal function (line 26)
|
|
lint:
contracts/base/OwnerPausable.sol#L17
Function order is incorrect, external function can not go after internal function (line 12)
|
|
lint:
contracts/base/SafeOwnable.sol#L42
Function order is incorrect, external function can not go after internal function (line 28)
|
|
lint:
contracts/base/UniswapV3CallbackBridge.sol#L40
Function order is incorrect, external view function can not go after internal function (line 34)
|
|
lint:
contracts/ClearingHouse.sol#L150
Function order is incorrect, external function can not go after public function (line 96)
|
|
lint:
contracts/ClearingHouse.sol#L653
Variable name must be in mixedCase
|
|
lint:
contracts/ClearingHouse.sol#L656
Variable name must be in mixedCase
|
|
lint:
contracts/DelegateApproval.sol#L105
Function order is incorrect, external view function can not go after external pure function (line 100)
|
|
lint:
contracts/Exchange.sol#L226
Code contains empty blocks
|
|
Foundry Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Foundry Test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
contract-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
contract-test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|