Added hierarchical lock for applying data updates #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
orweis
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This is a good effort but:
- You focused too much on restyling the code that it made reviewing very difficult
- You have little to no documentation / comments - (you actually removed comments) - on a super sensitive code like this - it's too risky
- and most crucial - the design breaks a core concurrency concept (queue for fetching) which would hurt the performance of this component dramatically (we actually discussed this in the design phase)
orweis
reviewed
Jan 29, 2025
orweis
reviewed
Jan 29, 2025
orweis
reviewed
Jan 29, 2025
orweis
approved these changes
Jan 29, 2025
danyi1212
force-pushed
the
dan/per-11699-fix-race-for-opal-data-updates
branch
from
1352480 to
027d81c
Compare
Co-authored-by: Or Weis <orweis@gmail.com>
Co-authored-by: Or Weis <orweis@gmail.com>
omer9564
reviewed
Feb 17, 2025
| if task is None: | ||
| raise RuntimeError("acquire() must be called from within a task.") | ||
|
|
||
| async with self._lock: |
There was a problem hiding this comment.
Why access the lock directly instead the Condition ?
There was a problem hiding this comment.
Suggested change
| async with self._lock: | |
| async with self._cond: |
Comment on lines
+49
to
+52
| self._locked_paths.add(path) | ||
| if task not in self._task_locks: | ||
| self._task_locks[task] = set() | ||
| self._task_locks[task].add(path) |
There was a problem hiding this comment.
locked_paths basically equals to combination of all task_locks values right ?
| entry=entry, | ||
| exc=e, | ||
| ) | ||
| raise Exception(f"Failed to fetch data for entry {entry.url}: {e}") |
| if task is None: | ||
| raise RuntimeError("release() must be called from within a task.") | ||
|
|
||
| async with self._lock: |
| raise RuntimeError(f"Task {task} cannot re-acquire lock on '{path}'.") | ||
|
|
||
| # Wait until there is no conflict with existing locked paths | ||
| while any(self._is_conflicting(path, lp) for lp in self._locked_paths): |
There was a problem hiding this comment.
Correct me if I'm wrong but wouldn't this cause you to aquire the condition underlying lock ( which is a single lock for all the tasks ), and then waiting for the path to be unlocked, which blocks also other paths from being processed ( because the lock is still locked )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers