Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing pre-commit workflow #683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix failing pre-commit workflow #683

wants to merge 2 commits into from

Conversation

daveads
Copy link
Contributor

@daveads daveads commented Oct 14, 2024

Fixed pre-commit failling test...

@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit db5bc30
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/670e34e0dff1d50008acc262

@daveads
Copy link
Contributor Author

daveads commented Oct 14, 2024

docformatter works.. properly now.. @gemanor @danyi1212

This pr should be attended to be merging any other pr...

@daveads
Copy link
Contributor Author

daveads commented Oct 14, 2024

I got the insight to fix this from the following sources:

https://github.com/PyCQA/docformatter/pull/287
https://github.com/PyGithub/PyGithub/issues/3058
https://github.com/Lightning-AI/torchmetrics/pull/2779
https://github.com/PyCQA/docformatter/issues/289

@daveads daveads changed the title fix fix failing pre-commit workflow Oct 14, 2024
@daveads daveads mentioned this pull request Oct 14, 2024
Open
danyi1212
danyi1212 approved these changes Oct 15, 2024
View reviewed changes
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
@daveads
Copy link
Contributor Author

daveads commented Oct 15, 2024

@danyi1212 This is ready for merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyi1212 danyi1212 danyi1212 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveads @danyi1212