Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tk add gist for GitHub #466

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Tk add gist for GitHub #466

wants to merge 12 commits into from

Conversation

ocap-kirk
Copy link
Contributor

I created a bash script that prompts the user for all the input required to setup an SSH connection. In the docs I just make a tip to link to it, but I could add to the page as well. Let me know what you think.

Link to gist: https://gist.github.com/ocap-kirk/803bdfb4592d6c60a12cc9d6121d5455

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for permitio-docs ready!

Name Link
🔨 Latest commit 52ce26a
🔍 Latest deploy log https://app.netlify.com/sites/permitio-docs/deploys/677c384f81262d00088da942
😎 Deploy Preview https://deploy-preview-466--permitio-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ocap-kirk ocap-kirk requested a review from RazcoDev December 19, 2024 21:14
@ocap-kirk
Copy link
Contributor Author

@RazcoDev I added you as reviewer because I know you're helped others in the community with the script and figured you'd be able to test to prove it works :)

Copy link
Contributor

@RazcoDev RazcoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - left some comments

docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this implementation!
Please address the comments (tried to have also suggestions to make it easier 😉)

docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
- A resource called 'internal_api' already created
- The admin role assigned to a user in the default and coke tenants

## Implementation Steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixing between schema and data in this tutorial makes it hard to follow, IMO. I'm recommending the following structure:

  • Schema / Policy Configuration
    • Configure tenant attribute key (without adding it to a tenant)
    • Configure time_base_groups user attribute (without assigning it to a user)
    • Create a condition set
    • Assign permissions to the condition set
  • Test the configuration
    • Create tenant with the key coke
    • Create a user with an assigned role and time_based_groups value
    • Run Permit check
      It would also be great to synchronize with @filipermit and do it with the new timeline component

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocap-kirk, since there's no new content here, @filipermit will take it. So no work is needed from your side on this ticket

docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
docs/how-to/build-policies/abac/temporary_role.mdx Outdated Show resolved Hide resolved
ocap-kirk and others added 10 commits January 6, 2025 14:04
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants