-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tk add gist for GitHub #466
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@RazcoDev I added you as reviewer because I know you're helped others in the community with the script and figured you'd be able to test to prove it works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this implementation!
Please address the comments (tried to have also suggestions to make it easier 😉)
- A resource called 'internal_api' already created | ||
- The admin role assigned to a user in the default and coke tenants | ||
|
||
## Implementation Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mixing between schema and data in this tutorial makes it hard to follow, IMO. I'm recommending the following structure:
- Schema / Policy Configuration
- Configure tenant attribute
key
(without adding it to a tenant) - Configure
time_base_groups
user attribute (without assigning it to a user) - Create a condition set
- Assign permissions to the condition set
- Configure tenant attribute
- Test the configuration
- Create tenant with the key
coke
- Create a user with an assigned role and time_based_groups value
- Run Permit check
It would also be great to synchronize with @filipermit and do it with the new timeline component
- Create tenant with the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocap-kirk, since there's no new content here, @filipermit will take it. So no work is needed from your side on this ticket
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
I created a bash script that prompts the user for all the input required to setup an SSH connection. In the docs I just make a tip to link to it, but I could add to the page as well. Let me know what you think.
Link to gist: https://gist.github.com/ocap-kirk/803bdfb4592d6c60a12cc9d6121d5455