Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG and GIF files with SVG URIs #298

Merged
merged 9 commits into from
Nov 22, 2020
Merged

Replace PNG and GIF files with SVG URIs #298

merged 9 commits into from
Nov 22, 2020

Conversation

KristjanESPERANTO
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO commented Nov 20, 2020

Magnifier:
before-after

Throbber:
before-after-throbber

Size before Size after
Magnifier 490 byte 259 byte
Throbber 4.831 byte 972 byte

@KristjanESPERANTO KristjanESPERANTO changed the title Replace PNG with SVG file Replace PNG and GIF with SVG file Nov 21, 2020
Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very promising! Please see my two comments…

Control.Geocoder.css Outdated Show resolved Hide resolved
Control.Geocoder.css Outdated Show resolved Hide resolved
@KristjanESPERANTO KristjanESPERANTO changed the title Replace PNG and GIF with SVG file Replace PNG and GIF files with SVG URIs Nov 21, 2020
@simon04
Copy link
Collaborator

simon04 commented Nov 21, 2020

The build fails because there are no more images to copy. To fix, …

diff --git a/package.json b/package.json
index ad79309..e0b1e3f 100644
--- a/package.json
+++ b/package.json
@@ -6,10 +6,9 @@
   "module": "src/index.js",
   "scripts": {
     "prepare": "npm run build",
-    "build": "npm run build:js && npm run build:css && npm run build:img && npm run build:demo-esbuild && npm run build:demo-rollup && npm run build:demo-webpack",
+    "build": "npm run build:js && npm run build:css && npm run build:demo-esbuild && npm run build:demo-rollup && npm run build:demo-webpack",
     "build:js": "rollup -c",
     "build:css": "cpr Control.Geocoder.css dist/Control.Geocoder.css --overwrite",
-    "build:img": "cpr images/ dist/images/ --overwrite",
     "build:demo-esbuild": "cd demo-esbuild && npm install && npm run build",
     "build:demo-rollup": "cd demo-rollup && npm install && npm run build",
     "build:demo-webpack": "cd demo-rollup && npm install && npm run build",

Control.Geocoder.css Outdated Show resolved Hide resolved
@KristjanESPERANTO
Copy link
Contributor Author

The build fails because there are no more images to copy. To fix, …

I have adapted the package.json.

Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for this PR!

@simon04 simon04 merged commit 1ec9ab5 into perliedman:master Nov 22, 2020
@KristjanESPERANTO
Copy link
Contributor Author

My pleasure. I am pleased that my changes have been accepted 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants