-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PNG and GIF files with SVG URIs #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising! Please see my two comments…
The build fails because there are no more images to copy. To fix, … diff --git a/package.json b/package.json
index ad79309..e0b1e3f 100644
--- a/package.json
+++ b/package.json
@@ -6,10 +6,9 @@
"module": "src/index.js",
"scripts": {
"prepare": "npm run build",
- "build": "npm run build:js && npm run build:css && npm run build:img && npm run build:demo-esbuild && npm run build:demo-rollup && npm run build:demo-webpack",
+ "build": "npm run build:js && npm run build:css && npm run build:demo-esbuild && npm run build:demo-rollup && npm run build:demo-webpack",
"build:js": "rollup -c",
"build:css": "cpr Control.Geocoder.css dist/Control.Geocoder.css --overwrite",
- "build:img": "cpr images/ dist/images/ --overwrite",
"build:demo-esbuild": "cd demo-esbuild && npm install && npm run build",
"build:demo-rollup": "cd demo-rollup && npm install && npm run build",
"build:demo-webpack": "cd demo-rollup && npm install && npm run build", |
I have adapted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much for this PR!
My pleasure. I am pleased that my changes have been accepted 🙂 |
Magnifier:
Throbber: