This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
test: long execution time scripts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Here some dummy test with some lil' changes to make the tests run. This PR demo how we can test Perfy to make it more robust. We still have to figure out a way to test the report result... Here is some details of what I did here and there. - **Linting and convention**: Might be cool to have a `.editorconfig` and some `eslint` to uniform the code. - **Templates can be valid js** Use of comments in `lib/index.template.html` - **Use existing protractor.confg.js to store the `perfyOptions`** - **Default report files path are absolute** Use of comments in `lib/index.template.html` - **Get ploty lib file from npm** - **Fix report pluralization** - **Add test case of long running script** Look at the playground - **Add node script to sync server and e2e test runner**
|
Here is a demo of the test is doing And here is a full screenshot of the report :
|
|
wow! there is so many neat stuff here. Can you however split this PR into small ones/features? |
|
Yes ! I will split and send it back by the week-end |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demo how we can test Perfy to make it more robust.
We still have to figure out a way to test the report result...
Here is some details of what I did here and there.
Might be cool to have a
.editorconfigand someeslintto uniform the code.Use of comments in
lib/index.template.htmlperfyOptionsUse of comments in
lib/index.template.htmlLook at the playground