Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct argument $request for WaterfallController::query() in RouteProvider. #473

Merged

Conversation

Charl13
Copy link

@Charl13 Charl13 commented Mar 2, 2022

Fix for:

xhgui_1        | 2022/03/01 16:28:08 [error] 36#36: *3 FastCGI sent in stderr: "PHP message: Slim Application Error:
xhgui_1        | Type: Pimple\Exception\UnknownIdentifierException
xhgui_1        | Message: Identifier "response.proxy" is not defined.
xhgui_1        | File: /var/www/xhgui/vendor/pimple/pimple/src/Pimple/Container.php
xhgui_1        | Line: 105
xhgui_1        | Trace: #0 /var/www/xhgui/src/ServiceProvider/RouteProvider.php(205): Pimple\Container->offsetGet()
xhgui_1        | #1 /var/www/xhgui/src/ServiceProvider/RouteProvider.php(31): XHGui\ServiceProvider\RouteProvider->XHGui\ServiceProvider\{closure}()
xhgui_1        | #2 [internal function]: XHGui\ServiceProvider\RouteProvider->XHGui\ServiceProvider\{closure}()
xhgui_1        | #3 /var/www/xhgui/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(40): call_user_func()
xhgui_1        | #4 /var/www/xhgui/vendor/slim/slim/Slim/Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke()
xhgui_1        | #5 /var/www/xhgui/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\Route->__invoke()
xhgui_1        | #6 /var/www/xhgui/vendor/slim/slim/Slim/Route.php(268): Slim\Route->callMiddlewareStack()
xhgui_1        | #7 /var/www/xhgui/vendor/slim/slim/Slim/App.php(503): Slim\Route" while reading response header from upstream, client: 172.18.0.1, server: , request: "GET /waterfall/data?remote_addr=172.18.0.1&request_start=1646148934&request_end=16461489

See ea83f10#r67785008

Charl13 referenced this pull request Mar 2, 2022
Remove static routes as it confuses Slim 3.x:
> Cannot bind an instance to a static closure in vendor/slim/slim/Slim/App.php:227
@glensc glensc changed the base branch from 0.21.x to 0.20.x March 2, 2022 16:34
@glensc glensc force-pushed the bug/waterfall-route-arg-correction branch from 6b72a66 to f78664e Compare March 2, 2022 16:36
@glensc glensc added this to the 0.20.5 milestone Mar 2, 2022
@glensc glensc merged commit 7f3df1b into perftools:0.20.x Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants