Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Flash messages after Slim upgrade to 3.x #451

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fix: Flash messages after Slim upgrade to 3.x #451

merged 1 commit into from
Jan 17, 2022

Conversation

luzip665
Copy link
Contributor

@luzip665 luzip665 commented Jan 17, 2022

Flash message work if there is a session_start.....

They could run with an array as storage, but I didn't get it working.

Also I added the assignment to AbstractController::render

@luzip665 luzip665 changed the base branch from 0.20.x to slim-upgrade January 17, 2022 09:50
@glensc
Copy link
Contributor

glensc commented Jan 17, 2022

They could run with an array as storage, but I didn't get it working.

array does not persist across page reloads, it's useful for testing only.

@glensc glensc merged commit 521e5b7 into perftools:slim-upgrade Jan 17, 2022
@luzip665 luzip665 deleted the slim-upgrade-flash-messages branch January 17, 2022 12:44
@glensc glensc added this to the 0.20.0 milestone Jan 17, 2022
@glensc glensc changed the title Slim upgrade flash messages Fix: Flash messages after Slim upgrade to 3.x Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants