Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum php version to 7.2 and allow 8.0 #391

Merged
merged 4 commits into from
Dec 23, 2020
Merged

Update minimum php version to 7.2 and allow 8.0 #391

merged 4 commits into from
Dec 23, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 21, 2020 •
edited
Loading

Because:

  1. 7.0, 7.1 are EOL, 7.2 will be EOL end of the month: https://www.php.net/supported-versions.php, https://www.php.net/eol.php
  2. using 7.2 as a minimum, allows to use Symfony 5.x, Slim 4.x packages
  3. 7.1 adds void return types, class const visibility, list() destructuring
  4. do not need wide support for old PHP versions, as can deploy the service standalone with docker

@glensc glensc requested a review from a team December 21, 2020 15:59
@glensc glensc force-pushed the min-php-7.2 branch 2 times, most recently from 0709168 to 653b435 Compare December 22, 2020 23:31
@glensc glensc added this to the Next milestone Dec 23, 2020
@glensc glensc merged commit 15062c2 into master Dec 23, 2020
@glensc glensc deleted the min-php-7.2 branch December 23, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @markstory