config: remove unused vars, restore defaults, add documentation #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These appear to be unused and were removed: * 'debug' * 'mode' * 'templates.path'
|
Thanks! |
Krinkle
added a commit
to Krinkle/xhgui
that referenced
this pull request
Jan 2, 2019
I'm not sure how 'templates.path' made its way to Slim\Views, but it does. This follows perftools#249, which broke the twig template rendering for me locally (I guess for others as well).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear to be unused and were removed:
The defaults from environment variables for
db.hostanddb.dbwere lost when we switched to using xhgui-collector withXHGUI_CONFIG_DIRset toxhgui/, because theconfig.default.phpfile inxhgui/doesn't have the environment-variable handling. This is now fixed.I'm not sure if the duplication can be avoided somehow, but at least it's now in sync again.