RunController::index: Use render() method

perftools · Dec 22, 2020 · a50fa6f · a50fa6f
1 parent 0620810
commit a50fa6f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/src/Controller/RunController.php b/src/Controller/RunController.php
@@ -71,14 +71,13 @@ public function index(Request $request, Response $response)
             'direction' => $result['direction'],
         ];
 
-        $this->_template = 'runs/list.twig';
-        $this->set([
+        $this->render('runs/list.twig', [
             'paging' => $paging,
             'base_url' => 'home',
             'runs' => $result['results'],
             'date_format' => $this->config('date.format'),
             'search' => $search,
-            'has_search' => strlen(implode('', $search)) > 0,
+            'has_search' => implode('', $search) !== '',
             'title' => $title,
         ]);
     }

diff --git a/src/ServiceProvider/RouteProvider.php b/src/ServiceProvider/RouteProvider.php
@@ -40,7 +40,7 @@ private function registerRoutes(Container $di, App $app)
         // Profile Runs routes
         $app->get('/', static function () use ($di, $app) {
             /** @var Controller\RunController $controller */
-            $controller = $app->controller = $di['runController'];
+            $controller = $di['runController'];
             $request = $app->request();
             $response = $app->response();
 

diff --git a/tests/Controller/RunTest.php b/tests/Controller/RunTest.php
@@ -25,7 +25,7 @@ public function setUp()
     public function testIndexEmpty()
     {
         $this->runs->index($this->app->request(), $this->app->response());
-        $result = $this->runs->templateVars();
+        $result = $this->view->all();
 
         $this->assertEquals('Recent runs', $result['title']);
         $this->assertFalse($result['has_search'], 'No search being done.');
@@ -47,7 +47,7 @@ public function testIndexSortedWallTime()
         ]);
 
         $this->runs->index($this->app->request(), $this->app->response());
-        $result = $this->runs->templateVars();
+        $result = $this->view->all();
         $this->assertEquals('Longest wall time', $result['title']);
         $this->assertEquals('wt', $result['paging']['sort']);
     }
@@ -61,7 +61,7 @@ public function testIndexSortedCpu()
         ]);
 
         $this->runs->index($this->app->request(), $this->app->response());
-        $result = $this->runs->templateVars();
+        $result = $this->view->all();
         $this->assertEquals('Most CPU time', $result['title']);
         $this->assertEquals('cpu', $result['paging']['sort']);
         $this->assertEquals('desc', $result['paging']['direction']);
@@ -76,7 +76,7 @@ public function testIndexWithSearch()
         ]);
 
         $this->runs->index($this->app->request(), $this->app->response());
-        $result = $this->runs->templateVars();
+        $result = $this->view->all();
         $this->assertEquals('Highest memory use', $result['title']);
         $this->assertEquals('mu', $result['paging']['sort']);
         $this->assertEquals('asc', $result['paging']['direction']);