Skip to content
This repository has been archived by the owner on Sep 26, 2020. It is now read-only.

Skipping built-in functions #33

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

panychek
Copy link
Contributor

@panychek panychek commented Dec 3, 2019

This patch adds the profiler.skip_built_in configuration parameter. See #32

I decided to introduce such option, since having profiler.flags turned out to not make much sense and being prone to errors.
For instance, if someone were to use extra flags from the tideways_xhprof extension, it would fail because XHGui doesn't support this data.
But all of the extensions have their own NO_BUILTINS flag, so it's the best way I could think of.

@markstory markstory merged commit 41428d1 into perftools:master Dec 4, 2019
@markstory
Copy link
Member

Thank you 👍

@glensc
Copy link
Contributor

glensc commented Feb 10, 2020

I added the same flag support to perftools/php-profiler:

That package is supposed eventually to become perftools/xhgui-collector:

* mode when using XHGui, because it only supports callgraphs and we can save the overhead. Use
* TIDEWAYS_FLAGS_NO_SPANS to disable timeline mode.
*
* v5 (tideways_xhprof): The TIDEWAYS_XHPROF_* constants are similar to the ones by XHProf, however you cannot use
* additional TIDEWAYS_XHPROF_FLAGS_MEMORY_* flags since XHGui does not support the extra data that they produce.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment correct?

however you cannot use additional TIDEWAYS_XHPROF_FLAGS_MEMORY_* flags since XHGui does not support the extra data that they produce.

because if it is, then why you still enable TIDEWAYS_XHPROF_FLAGS_MEMORY below?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants