Improve duet extraction, enable detection of rap notes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a single duet-style txt file instead of separate files for each singer. In addition, the program now finds duets that have a single track outside of the TRACK tags. In that case, the singer for any given note is determined by the last seen Singer attribute in a SENTENCE tag.
In the XML format, notes can have any combination of the Bonus, Rap, and FreeStyle attributes. It seems that all Rap notes are also FreeStyle. Since the txt format cannot combine free-style with another type, FreeStyle notes will only be marked F if they are not Bonus or Rap.
There is at least one song that is marked as duet and has two tracks (with notes outside the tracks), but the tracks have no Artist attribute: SingStar Party[DE]: Destiny's Child - Survivor In such a case, the Name attribute will be used as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program previously wasn't able to extract duets to a single txt file directly and created two files instead. In addition, duets that have Duet="Yes" in the XML but all notes in a single track (distinguished by the Singer attribute in SENTENCE tags) were not detected. Both are fixed with this PR.
In addition, rap and golden rap notes are now detected (previously only freestyle).