Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Pipestat output schema with looper output schema #65

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

donaldcampbelljr
Copy link
Contributor

Addresses #20

From previous discussion: if items are present but not defined under samples, they should be assumed to be project-level.

Therefore, this PR takes those extra top-level arguments and adds them to the project level.

…move error and pytest associated with error.
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #65 (bd2baa2) into dev (ca1e18d) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #65      +/-   ##
==========================================
- Coverage   87.75%   87.63%   -0.13%     
==========================================
  Files          17       17              
  Lines        2238     2240       +2     
==========================================
- Hits         1964     1963       -1     
- Misses        274      277       +3     
Files Changed Coverage Δ
pipestat/parsed_schema.py 89.77% <0.00%> (-1.61%) ⬇️
tests/test_parsed_schema.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@donaldcampbelljr
Copy link
Contributor Author

Note:
The output schema can be written as so:

pipeline_name: test_pipe
samples:
  number_of_things:
    type: integer
    description: "Number of things"
  percentage_of_things:
    type: number
    description: "Percentage of things"
  name_of_something:
    type: string
    description: "Name of something"
  switch_value:
    type: boolean
    description: "Is the switch on or off"

testing_project_result:
  type: string
  description: "misc project result"
more_number_of_things:
  type: integer
  description: "Number of things, min 20, multiple of 10"
  multipleOf: 10

However, if using:

properties: 
  samples:

pipestat will still throw an exception 'properties' is missing required key(s): type, description during schema validation.

@donaldcampbelljr donaldcampbelljr merged commit 9746333 into dev Aug 7, 2023
5 checks passed
@donaldcampbelljr donaldcampbelljr deleted the issue20_output_schema branch August 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant