Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pephub backend to Pipestat #187

Merged
merged 35 commits into from
Jul 18, 2024
Merged

Add pephub backend to Pipestat #187

merged 35 commits into from
Jul 18, 2024

Conversation

donaldcampbelljr
Copy link
Contributor

@donaldcampbelljr donaldcampbelljr commented May 2, 2024 •
edited
Loading

Primarily addresses #125

Also added fixes for #189 , #190

@donaldcampbelljr
Copy link
Contributor Author

Basic reporting now works:
image

@donaldcampbelljr
begin work for select_records pephubbackend
02d573f
@donaldcampbelljr
add more for pephubbackend select_records
f8b8721
@donaldcampbelljr
fix retrieve_many for pephub backend
e13f9bd
@donaldcampbelljr
add pephubclient to requirements
e56c813
@donaldcampbelljr
add record and result removal for pephubclient backend
fd5f8c6
@donaldcampbelljr
remove unused code
765cfb3
@donaldcampbelljr
comment out removal code to see if it prevents tests hanging
e31d164
@donaldcampbelljr
comment out pephub testing for now
e7750c1
@donaldcampbelljr
add skipping to pephub via db dependencies and comment regarding PHC
8172545
@donaldcampbelljr
change gha to black stable
5ceea72
@donaldcampbelljr
update manifest to include pephub backend
11c67c8
@donaldcampbelljr
Merge branch 'refs/heads/dev' into dev_pephub_backend
891923e
@donaldcampbelljr
add pephub url as constant
2098bc0
@donaldcampbelljr
work towards setting and getting statuses from pephub
6523c02
@donaldcampbelljr
fix returning status for PEPhub backend
25b0b3f
@donaldcampbelljr
clean up commented code
5c95fb0
@donaldcampbelljr
add results formatting to pephub reported results
38804d8
@donaldcampbelljr
add warning if history_enabled set to true
90992d5
@donaldcampbelljr
add warning for retrieve_history
3be2f72
@donaldcampbelljr
add warning for linking results and using pephubbackend
4110c26
@donaldcampbelljr
add warnings for list recent results and summarize
70af18f
@donaldcampbelljr
add exception for bad registry path
4b6771c
@donaldcampbelljr
clean up, add docstrings
7e4c716
@donaldcampbelljr
update more docstrings
d81456e
@donaldcampbelljr
change warning to debug
2463db1
@donaldcampbelljr
remove todos
0f41a6f
@donaldcampbelljr
remove duplicate code for record_identifier
4c31201
@donaldcampbelljr
Copy link
Contributor Author

Test Coverage is at ~ 87%

khoroshevskyi
khoroshevskyi requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few fixes needed

requirements/requirements-pephub-backend.txt Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_pipestat.py Show resolved Hide resolved
pipestat/pipestat.py Show resolved Hide resolved
pipestat/pipestat.py Show resolved Hide resolved
pipestat/backends/pephub_backend/pephubbackend.py Outdated Show resolved Hide resolved
pipestat/backends/pephub_backend/pephubbackend.py Show resolved Hide resolved
@donaldcampbelljr donaldcampbelljr merged commit 9230e21 into dev Jul 18, 2024
5 checks passed
@donaldcampbelljr donaldcampbelljr deleted the dev_pephub_backend branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoroshevskyi khoroshevskyi khoroshevskyi requested changes

@nsheff nsheff Awaiting requested review from nsheff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldcampbelljr @khoroshevskyi