Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum type for entity level type/name #360

Closed
vreuter opened this issue Apr 17, 2023 · 2 comments
Closed

Enum type for entity level type/name #360

vreuter opened this issue Apr 17, 2023 · 2 comments

Comments

@vreuter
Copy link
Member

vreuter commented Apr 17, 2023

We have the notion of "project"-level and "sample"-level entities and operations. Right now, some of the behavioral and messaging differences for these concepts are controlled through passing the strings "sample" or "project" to toggle between the two. This should be better formalized at the type level with an enum type to disambiguate, which would likely allow better editor hints and type annotation / checking.

@vreuter vreuter changed the title Enum type for entity level type/name ? Enum type for entity level type/name Apr 17, 2023
@donaldcampbelljr donaldcampbelljr added this to the 1.7.0 milestone Oct 6, 2023
@donaldcampbelljr donaldcampbelljr modified the milestones: 1.7.0, v1.8.0 Jan 17, 2024
@donaldcampbelljr
Copy link
Contributor

This could be tackled along with the pipestat refactoring.

@donaldcampbelljr
Copy link
Contributor

Ok, I added this enum and did some refactoring for the upcoming 1.8.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants