ThrowsPhpDocRule: fixed double creation of virtual node when a trait …

…is used (#44)
pepakriz · Dec 2, 2018 · 9d41e60 · 9d41e60
1 parent a1cb24d
commit 9d41e60
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/Rules/ThrowsPhpDocRule.php b/src/Rules/ThrowsPhpDocRule.php
@@ -47,6 +47,9 @@
 class ThrowsPhpDocRule implements Rule
 {
 
+	private const ATTRIBUTE_HAS_CLASS_METHOD_END = '__HAS_CLASS_METHOD_END__';
+	private const ATTRIBUTE_HAS_TRY_CATCH_END = '__HAS_TRY_CATCH_END__';
+
 	/**
 	 * @var CheckedExceptionService
 	 */
@@ -156,7 +159,10 @@ private function processTryCatch(TryCatch $node, Scope $scope): array
 
 		$this->throwsScope->enterToTryCatch($node);
 
-		$node->stmts[] = new TryCatchTryEnd($node);
+		if (!$node->hasAttribute(self::ATTRIBUTE_HAS_TRY_CATCH_END)) {
+			$node->setAttribute(self::ATTRIBUTE_HAS_TRY_CATCH_END, true);
+			$node->stmts[] = new TryCatchTryEnd($node);
+		}
 
 		return [];
 	}
@@ -341,7 +347,10 @@ private function processClassMethod(ClassMethod $node, Scope $scope): array
 			$this->throwsScope->enterToThrowsAnnotationBlock($methodReflection->getThrowType());
 		}
 
-		$node->stmts[] = new ClassMethodEnd($node);
+		if (!$node->hasAttribute(self::ATTRIBUTE_HAS_CLASS_METHOD_END)) {
+			$node->setAttribute(self::ATTRIBUTE_HAS_CLASS_METHOD_END, true);
+			$node->stmts[] = new ClassMethodEnd($node);
+		}
 
 		return [];
 	}