top layer 위에 floating element 띄우기 #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “:rocket:” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
- floating action 수정: floating element의 조상 중 top layer에 표시되는 요소가 있다면 거기에 추가하고 없으면 body에 추가합니다. floating element와 상호작용할 수 있게 됨. 관련 이슈: whatwg/html#9936 - Alert 컴포넌트도 Dialog 컴포넌트 사용하도록 함. 세팅 모달 위에 Alert가 이제 잘 뜸
devunt
force-pushed
the
fix/floating-over-top-layer
branch
from
d7065cb to
caddac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈: A popover on top of a modal dialog should be interactable whatwg/html#9936