You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, minifront indiscriminately displays the asset icon provided by the prax asset registry in the ValueViewComponent. Example:
The challenge is that this can mislead users. For example, Penumbra can connect to multiple Cosmos chains that each may have a Bitcoin variation using the same Bitcoin icon. For users, it would be impossible to distinguish them in the UI. There should be a way for frontends to be able to label assets depending on the channel source, so it's clear to users where it is coming from.
Task: Add a badges field to the Metadata proto that allows the registry to add the ibc chain icon to the asset's badge list.
Steps:
Update the Metadata proto in penumbra-zone/penumbra to include a new badges field (type: ~Vec<Image>)
Pull in latest proto defs to registry. Add the chain icon to the respective ibc asset's metadata. Regenerate registry and ship new version of registry npm package.
Pull in latest proto defs to minifront. Update to latest registry package. Update ValueViewComponent to show badge on top of icon.
The text was updated successfully, but these errors were encountered:
The rendering should be a circle 1/2 of the radius of the main icon (so 1/4 the area) and placed in the lower right quadrant, aligned with the edge of the icons:
## Describe your changes
Web apps are currently unable to visually distinguish certain IBC assets
that represent rehypothecated tokens. Aka, Bitcoin from Osmosis or
Nomic. Both of their metadata possess images of the plain Bitcoin logo.
This proto change proposes to add a new field: `badges`. It gives
entities like the [prax
registry](https://github.com/prax-wallet/registry) the ability to add
source chain icons to the metadata of assets. Frontends can then display
these badges [on top
of](penumbra-zone/web#1864 (comment))
the asset icon.
## Issue ticket number and link
penumbra-zone/web#1864prax-wallet/registry#97
## Checklist before requesting a review
- [x] (not relevant) I have added guiding text to explain how a reviewer
should test these changes.
- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:
> Only a protobuf schema update
At the moment, minifront indiscriminately displays the asset icon provided by the prax asset registry in the
ValueViewComponent
. Example:The challenge is that this can mislead users. For example, Penumbra can connect to multiple Cosmos chains that each may have a Bitcoin variation using the same Bitcoin icon. For users, it would be impossible to distinguish them in the UI. There should be a way for frontends to be able to label assets depending on the channel source, so it's clear to users where it is coming from.
Task: Add a
badges
field to the Metadata proto that allows the registry to add the ibc chain icon to the asset's badge list.Steps:
penumbra-zone/penumbra
to include a newbadges
field (type: ~Vec<Image>
)ValueViewComponent
to show badge on top of icon.The text was updated successfully, but these errors were encountered: