Allow building client crates without rocksdb #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required: - feature gating `cnidarium` in `penumbra-app` - removing the stateless transaction check in the view crate - removing the ceremony contribution command from `pcli` Closes #4885
cronokirby
force-pushed
the
4885-app-crate-deps
branch
from
0b24598
to
faad4e3
Compare
The first point of three was removed, along with the associated functionality of performing stateless checks, so let's renumber the comments to make sense.
|
Great work. I recorded some of the research findings in #4885. Testing locally, |
conorsch
approved these changes
Oct 9, 2024
|
I think a lot of the warnings might just be that certain package code paths become unused without certain features |
conorsch
added a commit
that referenced
this pull request
Oct 10, 2024
Follow-up to #4892. During review of that PR, I noticed that `cargo run -p pcli` was emitting a lot of warnings about unused imports. Here I try to address those warnings, by adding more conditional imports based on the `component` feature.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required:
cnidariuminpenumbra-apppcliCloses #4885
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
How to test this:
run
cargo build --bin pcli -p pcli(and pclientd, and pindexer) and observe that rocksdb is not built.