feat: Noble forwarding address registration in pcli #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbuc
changed the title
zbuc
changed the title
|
Do we want to do the auto-registration flow as a part of this PR, or in a subsequent one? |
cronokirby
approved these changes
Sep 26, 2024
IMO a subsequent PR. I think what is implemented in this PR is useful for testing and maybe some particular use cases, but we should make the default be to use the automatically cycling addresses to be implemented in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adds support for registering Noble forwarding addresses, for example:
pcli tx register-forwarding-account --noble-node http://noble-testnet-grpc.polkachu.com:21590 --channel channel-216 --address-or-index 2Note that your address will need to be funded prior to being registered; the faucet can be used along with the
pcli view noble-address ADDRESS_OR_INDEX --channel channel-216command to get test funds.Issue ticket number and link
Closes #4857
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: