dex: fold execution budget in DexParameters
#4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
erwanor
added
consensus-breaking
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
conorsch
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
This LGTM. I used the same procedure as in #4564 (comment) to test: created devnet, opened LP, migrated, confirmed LP still executable post-migration.
TalDerei
approved these changes
Jun 14, 2024
|
retro point of process: I ran 
performed governance proposal and chain halt, ran the migration, restarted chain, and was able to view and swap against position. confirmed everything's working post-migration, and closing as complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Close #4602, and simplifies the execution breaker as well, fixing an edge case that would cause only successful executions to be counted.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: