Skip to content

async packet relay working now, refactored into build_penumbra_tx

Sign in for the full log view
GitHub Actions / clippy-no-default-features failed Feb 21, 2024 in 1s

clippy-no-default-features

8 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 8
Warning 0
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check failure on line 101 in crates/relayer/src/util/profiling.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unnecessary use of `.write(true)` because there is `.append(true)` 

error: unnecessary use of `.write(true)` because there is `.append(true)`
   --> crates/relayer/src/util/profiling.rs:101:9
    |
101 |         .write(true)
    |         ^^^^^^^^^^^^ help: remove `.write(true)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
    = note: `-D clippy::ineffective-open-options` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`

Check failure on line 101 in crates/relayer/src/util/profiling.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unnecessary use of `.write(true)` because there is `.append(true)` 

error: unnecessary use of `.write(true)` because there is `.append(true)`
   --> crates/relayer/src/util/profiling.rs:101:9
    |
101 |         .write(true)
    |         ^^^^^^^^^^^^ help: remove `.write(true)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
    = note: `-D clippy::ineffective-open-options` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`

Check failure on line 540 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

using `clone` on type `Duration` which implements the `Copy` trait 

error: using `clone` on type `Duration` which implements the `Copy` trait
   --> crates/relayer/src/chain/penumbra/chain.rs:540:13
    |
540 |             config.rpc_timeout.clone(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.rpc_timeout`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`

Check failure on line 406 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

question mark operator is useless here 

error: question mark operator is useless here
   --> crates/relayer/src/chain/penumbra/chain.rs:403:40
    |
403 |   ...                   return Ok(bs
    |  ______________________________^
404 | | ...                       .id
405 | | ...                       .expect("detected transaction missing id")
406 | | ...                       .try_into()?);
    | |_______________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
    = note: `-D clippy::needless-question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`
help: try removing question mark and `Ok()`
    |
403 ~                                 return bs
404 +                                     .id
405 +                                     .expect("detected transaction missing id")
406 ~                                     .try_into();
    |

Check failure on line 332 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> crates/relayer/src/chain/penumbra/chain.rs:332:13
    |
332 |             &self.config.kms_config.spend_key.full_viewing_key(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.kms_config.spend_key.full_viewing_key()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 540 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

using `clone` on type `Duration` which implements the `Copy` trait 

error: using `clone` on type `Duration` which implements the `Copy` trait
   --> crates/relayer/src/chain/penumbra/chain.rs:540:13
    |
540 |             config.rpc_timeout.clone(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.rpc_timeout`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`

Check failure on line 406 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

question mark operator is useless here 

error: question mark operator is useless here
   --> crates/relayer/src/chain/penumbra/chain.rs:403:40
    |
403 |   ...                   return Ok(bs
    |  ______________________________^
404 | | ...                       .id
405 | | ...                       .expect("detected transaction missing id")
406 | | ...                       .try_into()?);
    | |_______________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
    = note: `-D clippy::needless-question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`
help: try removing question mark and `Ok()`
    |
403 ~                                 return bs
404 +                                     .id
405 +                                     .expect("detected transaction missing id")
406 ~                                     .try_into();
    |

Check failure on line 332 in crates/relayer/src/chain/penumbra/chain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> crates/relayer/src/chain/penumbra/chain.rs:332:13
    |
332 |             &self.config.kms_config.spend_key.full_viewing_key(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.kms_config.spend_key.full_viewing_key()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
View more details on GitHub Actions