v2 Penumbra support in Hermes #29
clippy-no-default-features
18 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 18 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check failure on line 101 in crates/relayer/src/util/profiling.rs
github-actions / clippy-no-default-features
unnecessary use of `.write(true)` because there is `.append(true)`
error: unnecessary use of `.write(true)` because there is `.append(true)`
--> crates/relayer/src/util/profiling.rs:101:9
|
101 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
= note: `-D clippy::ineffective-open-options` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`
Check failure on line 101 in crates/relayer/src/util/profiling.rs
github-actions / clippy-no-default-features
unnecessary use of `.write(true)` because there is `.append(true)`
error: unnecessary use of `.write(true)` because there is `.append(true)`
--> crates/relayer/src/util/profiling.rs:101:9
|
101 | .write(true)
| ^^^^^^^^^^^^ help: remove `.write(true)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options
= note: `-D clippy::ineffective-open-options` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ineffective_open_options)]`
Check failure on line 514 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
using `clone` on type `Duration` which implements the `Copy` trait
error: using `clone` on type `Duration` which implements the `Copy` trait
--> crates/relayer/src/chain/penumbra/chain.rs:514:13
|
514 | config.rpc_timeout.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.rpc_timeout`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
Check failure on line 409 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
question mark operator is useless here
error: question mark operator is useless here
--> crates/relayer/src/chain/penumbra/chain.rs:406:40
|
406 | ... return Ok(bs
| ______________________________^
407 | | ... .id
408 | | ... .expect("detected transaction missing id")
409 | | ... .try_into()?);
| |_______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `-D clippy::needless-question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`
help: try removing question mark and `Ok()`
|
406 ~ return bs
407 + .id
408 + .expect("detected transaction missing id")
409 ~ .try_into();
|
Check failure on line 336 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/relayer/src/chain/penumbra/chain.rs:336:13
|
336 | &self.config.kms_config.spend_key.full_viewing_key(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.kms_config.spend_key.full_viewing_key()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 514 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
using `clone` on type `Duration` which implements the `Copy` trait
error: using `clone` on type `Duration` which implements the `Copy` trait
--> crates/relayer/src/chain/penumbra/chain.rs:514:13
|
514 | config.rpc_timeout.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.rpc_timeout`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
Check failure on line 409 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
question mark operator is useless here
error: question mark operator is useless here
--> crates/relayer/src/chain/penumbra/chain.rs:406:40
|
406 | ... return Ok(bs
| ______________________________^
407 | | ... .id
408 | | ... .expect("detected transaction missing id")
409 | | ... .try_into()?);
| |_______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `-D clippy::needless-question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`
help: try removing question mark and `Ok()`
|
406 ~ return bs
407 + .id
408 + .expect("detected transaction missing id")
409 ~ .try_into();
|
Check failure on line 336 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/relayer/src/chain/penumbra/chain.rs:336:13
|
336 | &self.config.kms_config.spend_key.full_viewing_key(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.config.kms_config.spend_key.full_viewing_key()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 676 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
variable does not need to be mutable
error: variable does not need to be mutable
--> crates/relayer/src/chain/penumbra/chain.rs:676:13
|
676 | let mut view_client = self.rt.block_on(self.view_client.lock()).clone();
| ----^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `-D unused-mut` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_mut)]`
Check failure on line 674 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `denom`
error: unused variable: `denom`
--> crates/relayer/src/chain/penumbra/chain.rs:674:9
|
674 | denom: Option<&str>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_denom`
Check failure on line 673 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `key_name`
error: unused variable: `key_name`
--> crates/relayer/src/chain/penumbra/chain.rs:673:9
|
673 | key_name: Option<&str>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_key_name`
Check failure on line 676 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `view_client`
error: unused variable: `view_client`
--> crates/relayer/src/chain/penumbra/chain.rs:676:17
|
676 | let mut view_client = self.rt.block_on(self.view_client.lock()).clone();
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_view_client`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Check failure on line 676 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
variable does not need to be mutable
error: variable does not need to be mutable
--> crates/relayer/src/chain/penumbra/chain.rs:676:13
|
676 | let mut view_client = self.rt.block_on(self.view_client.lock()).clone();
| ----^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `-D unused-mut` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_mut)]`
Check failure on line 674 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `denom`
error: unused variable: `denom`
--> crates/relayer/src/chain/penumbra/chain.rs:674:9
|
674 | denom: Option<&str>,
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_denom`
Check failure on line 673 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `key_name`
error: unused variable: `key_name`
--> crates/relayer/src/chain/penumbra/chain.rs:673:9
|
673 | key_name: Option<&str>,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_key_name`
Check failure on line 676 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused variable: `view_client`
error: unused variable: `view_client`
--> crates/relayer/src/chain/penumbra/chain.rs:676:17
|
676 | let mut view_client = self.rt.block_on(self.view_client.lock()).clone();
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_view_client`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
Check failure on line 66 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused import: `BalancesRequest`
error: unused import: `BalancesRequest`
--> crates/relayer/src/chain/penumbra/chain.rs:66:9
|
66 | BalancesRequest, GasPricesRequest,
| ^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
Check failure on line 66 in crates/relayer/src/chain/penumbra/chain.rs
github-actions / clippy-no-default-features
unused import: `BalancesRequest`
error: unused import: `BalancesRequest`
--> crates/relayer/src/chain/penumbra/chain.rs:66:9
|
66 | BalancesRequest, GasPricesRequest,
| ^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`