Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default excluded_sequences value #26

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add default excluded_sequences value #26

merged 1 commit into from
Apr 30, 2024

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented Apr 30, 2024

Closes: #25

Description

Fixes an issue with a todo!() for excluded_sequences introduced when merging upstream changes by setting the value to an empty Vec for Penumbra chains. If we ever do intend to introduce excluded sequences support, the Penumbra config struct will need to be modified to account for them.


@zbuc zbuc changed the base branch from master to main April 30, 2024 17:12
@zbuc zbuc requested a review from aubrika April 30, 2024 17:13
Copy link

@aubrika aubrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubrika aubrika merged commit eec44e1 into main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hermes not working on Penumbra testnet 73
2 participants