Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add container build workflow for fork #24

Merged
merged 2 commits into from
Apr 12, 2024
Merged

ci: add container build workflow for fork #24

merged 2 commits into from
Apr 12, 2024

Conversation

conorsch
Copy link

@conorsch conorsch commented Apr 9, 2024

We cannot depend on the upstream informalsystems/hermes repo for CI deployments, because we need the forked Hermes code for compatiblity with Penumbra chains. Added a new workflow that will publish as ghcr.io/penumbra-zone/hermes, and removed the informalsystems one.

@zbuc
Copy link
Member

zbuc commented Apr 9, 2024

@conorsch I spent a lot of time working on fixing the CI tests in #23 and it seems good if we can keep as many of the tests in place as we can.

@conorsch
Copy link
Author

conorsch commented Apr 9, 2024

Oh, sick, my big goal here is to re-add a container build so we can consume it in CI deployments. I'll edit this to just add the container workflow, and wait for #23 to land to rebase this!

@conorsch
Copy link
Author

conorsch commented Apr 9, 2024

This PR now only affects the container-build logic. Will wait until other PRs land, so this can be rebased, and we keep CI green. I can't test the new container workflow until it lands on main, so there might be a follow-up, but will handle that when the time comes.

@conorsch conorsch changed the title ci: update workflows for forked repo ci: add container build workflow for fork Apr 9, 2024
@conorsch conorsch force-pushed the container-image branch 2 times, most recently from ad07153 to f0bb9e8 Compare April 12, 2024 16:59
We cannot depend on the upstream `informalsystems/hermes` repo for CI
deployments, because we need the forked Hermes code for compatiblity
with Penumbra chains. Added a new workflow that will publish as
`ghcr.io/penumbra-zone/hermes`, and removed the informalsystems one.
@conorsch conorsch marked this pull request as ready for review April 12, 2024 17:35
This single job was failing due to timeout. Bumping its timeout.
We could also switch to a faster runner, but a separate job takes ~1h,
which is really where we should focus attention.
@conorsch
Copy link
Author

Ready for review. I tacked on one more commit to bump the timeout on one of the CI jobs that was failing due to overrunning the 20m limit. If we end up maintaining this fork for a long time, maybe someday it'll be worthwhile to focus on speeding up CI—but at the low rate of change here, not worthwhile right now.

@conorsch conorsch merged commit 7252b23 into main Apr 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants