Bump shibboleth-sp-nginx to Debian 12 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyliu-q
reviewed
Nov 5, 2023
| @@ -1,17 +1,15 @@ | |||
| # Build stage | |||
| FROM debian:buster-slim AS build | |||
|
|
|||
| ENV NGINX_VERSION=1.18.0-2~buster | |||
There was a problem hiding this comment.
Wait just curious why do we no longer need this lol
There was a problem hiding this comment.
Honestly bc I don't know what the most recent version of nginx in that repository is and don't see why we need to pin to a specific Nginx version if the docker image is basically never rebuilt anyway. Seems like it will just make it harder to update in the future.
Maybe there's some reason why it's important to pin the version of nginx like that?
joyliu-q
added a commit
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root problem: the platform backend Docker image is failing to build. Pipenv is failing to lock with a bunch of messages about
Requires-Python >=3.8we THINK due to python 3.7 no longer being supported (support ended on June 27, 2023). So we want to bump platform backend to python 3.11.To do this, we want to bump the Debian version of the
shibboleth-sp-nginxDocker image to Debian 12 (bookworm) which comes with 3.11 so that in the platform backend image (which extendsshibboleth-sp-nginx) we can easily installpython3.11-devwithout needing to build python from scratch (which takes ages) or backport. Debian buster only comes with 3.7 so you can't simply installpython3.8-devor higher (e.g.python3.11-dev)