i am but a servant to the great ol' Code Coverage

pennlabs · Oct 22, 2023 · 210c1c4 · 210c1c4
1 parent ef2e1c4
commit 210c1c4
Show file tree

Hide file tree

Showing 3 changed files with 85 additions and 2 deletions.
diff --git a/cdk/kittyhawk/src/application/redis.ts b/cdk/kittyhawk/src/application/redis.ts
@@ -47,7 +47,7 @@ export class RedisApplication extends Application {
         },
         spec: {
           storageClassName: `${appname}-redis-storage`,
-          accessModes: ["ReadWriteMany"], // TODO: WHAT IS THIS
+          accessModes: ["ReadWriteMany"], // TODO: ask Redis folks
           capacity: {
             storage: Quantity.fromString("1Gi"),
           },
@@ -62,7 +62,7 @@ export class RedisApplication extends Application {
         },
         spec: {
           storageClassName: `${appname}-redis-storage`,
-          accessModes: ["ReadWriteMany"], // TODO: WHAT IS THIS
+          accessModes: ["ReadWriteMany"], // TODO: ask Redis folks
           resources: {
             requests: {
               storage: Quantity.fromString("1Gi"),

diff --git a/cdk/kittyhawk/test/__snapshots__/deployment.test.ts.snap b/cdk/kittyhawk/test/__snapshots__/deployment.test.ts.snap
diff --git a/cdk/kittyhawk/test/deployment.test.ts b/cdk/kittyhawk/test/deployment.test.ts
@@ -0,0 +1,21 @@
+import { Construct } from "constructs";
+import { Container, Deployment } from "../src";
+import { chartTest, failingTestNoGitSha } from "./utils";
+
+export function buildDeploymentDefault(scope: Construct) {
+  new Deployment(scope, "container", {
+    image: "pennlabs/website",
+    tag: "latest",
+  });
+}
+
+export function buildContainerDefault() {
+  new Container({
+    image: "pennlabs/website",
+    tag: "latest",
+  });
+}
+
+test("Deployment -- No Git Sha", () =>
+  failingTestNoGitSha(buildDeploymentDefault));
+test("Deployment -- Default", () => chartTest(buildDeploymentDefault));