Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove migrations #498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove migrations #498

wants to merge 1 commit into from
+4 −101

Conversation

b-yap
Copy link
Contributor

@b-yap b-yap commented Oct 4, 2024 •
edited
Loading

Closes #454.

@b-yap b-yap force-pushed the 454-remove-the-custom-migration-logic-from-all-runtimes branch from 582e879 to 86dcb70 Compare October 9, 2024 10:26
@b-yap
Copy link
Contributor Author

b-yap commented Oct 10, 2024 •
edited
Loading

runtime upgrade tested Amplitude chopsticks

Screenshot 2024-10-10 at 10 54 44 PM Screenshot 2024-10-10 at 10 54 38 PM

No abnormal effects.

@b-yap b-yap marked this pull request as ready for review October 11, 2024 07:29
@b-yap b-yap requested a review from a team October 11, 2024 07:29
ebma
ebma approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

runtime/amplitude/src/lib.rs
Comment on lines 161 to 165
// Custom storage version bump
use frame_support::{
pallet_prelude::StorageVersion,
traits::{GetStorageVersion, OnRuntimeUpgrade},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these imports can be removed in all runtimes.

TorstenStueber
TorstenStueber approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

gianfra-t
gianfra-t approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. But let's not merge this before creating the Pendulum release for the upgrade! I think it's not yet there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

@TorstenStueber TorstenStueber TorstenStueber approved these changes

@gianfra-t gianfra-t gianfra-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the custom migration logic from all runtimes
4 participants
@b-yap @ebma @TorstenStueber @gianfra-t