Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EURC to Zenlink ID map #468

Merged
merged 1 commit into from
May 17, 2024
Merged

Add EURC to Zenlink ID map #468

merged 1 commit into from
May 17, 2024

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented May 15, 2024

Closes: tasks/317.
Related: Pair creation.

Requirement

  • In order to add a Zenlink pair with stellar asset EURC, we need to add it manually to both mapping functions for Zenlink.
  • Since this change requires a runtime upgrade, we will also include the following Spacewalk assets to the mapping functions for Zenlink: AUDD.s, NGNC.s, BRL.s, TZS.s

@gianfra-t gianfra-t requested a review from a team May 15, 2024 16:31
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I already forgot that we have this mapping 👍

@gianfra-t gianfra-t merged commit 0560321 into main May 17, 2024
3 checks passed
@gianfra-t gianfra-t deleted the task-317-add-pen-eurc-pool branch May 17, 2024 14:41
@vadaynujra vadaynujra changed the title Add EURC to Zenlink ID map. Add EURC to Zenlink ID map May 23, 2024
@vadaynujra
Copy link

So this step would be required each time we want to add any of the Spacewalk assets to a pool on Zenlink @gianfra-t ?

@ebma
Copy link
Member

ebma commented May 23, 2024

Yes, unfortunately. We can already add potential support for other Stellar assets in advance but they have to be added to this list. So if you already have some Spacewalk assets in mind that you want to have in the near future, let us know.

@vadaynujra
Copy link

vadaynujra commented May 23, 2024

I think it makes sense to keep that option, without having to do a runtime upgrade each time. Also, I don't see any downside of already mapping them. Therefore, updated the description of the ticket to include most of the Spacewalk assets.

@gianfra-t
Copy link
Contributor Author

@vadaynujra since we already close this PR I am afraid we will miss this. I can add it as a to-do list in the original task if you like.

@vadaynujra
Copy link

@gianfra-t would that mean we add the mapping functions for the assets also as part of the next runtime upgrade? If yes, please do that.

@ebma
Copy link
Member

ebma commented May 23, 2024

If it's very urgent I can also quickly add them now before preparing the runtime upgrade for tomorrow. Otherwise you'd have to wait probably a month or so, not sure when we do the next runtime upgrade on Pendulum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants