-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EURC to Zenlink ID map #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, I already forgot that we have this mapping 👍
So this step would be required each time we want to add any of the Spacewalk assets to a pool on Zenlink @gianfra-t ? |
Yes, unfortunately. We can already add potential support for other Stellar assets in advance but they have to be added to this list. So if you already have some Spacewalk assets in mind that you want to have in the near future, let us know. |
I think it makes sense to keep that option, without having to do a runtime upgrade each time. Also, I don't see any downside of already mapping them. Therefore, updated the description of the ticket to include most of the Spacewalk assets. |
@vadaynujra since we already close this PR I am afraid we will miss this. I can add it as a to-do list in the original task if you like. |
@gianfra-t would that mean we add the mapping functions for the assets also as part of the next runtime upgrade? If yes, please do that. |
If it's very urgent I can also quickly add them now before preparing the runtime upgrade for tomorrow. Otherwise you'd have to wait probably a month or so, not sure when we do the next runtime upgrade on Pendulum. |
Closes: tasks/317.
Related: Pair creation.
Requirement
EURC
, we need to add it manually to both mapping functions for Zenlink.AUDD.s
,NGNC.s
,BRL.s
,TZS.s