170 Call Gitlab CI job to Automate Runtime Release #430
Conversation
b-yap
changed the title
There was a problem hiding this comment.
Looks very good @b-yap !! This will save us a lot of time and potential errors.
I only have one comment but it may not be feasible. Since common.js and the constants are taken from the transaction builder repo, do you think it makes sense to fetch those file as one more step in the last work? So we don't have to keep track of both of them.
I think we could just use run: curl ... but then I don't know because the repo is private.
There was a problem hiding this comment.
Wow really cool stuff @b-yap, very impressive! I think for the .js stuff, we should strip this down and reduce the files to maybe just one as there is plenty of code we don't need. Some other changes are required to make this work in CI but it already looks great overall 🙏
Since common.js and the constants are taken from the transaction builder repo, do you think it makes sense to fetch those file as one more step in the last work? So we don't have to keep track of both of them.
Regarding this, I agree and would prefer not to link both of them but keep the code here to a minimum.
There was a problem hiding this comment.
@b-yap Nice PR, this will really improve our lives.
Some major missing part is of course the creation of a GitHub release but I assume that you will add this to the GitLab CI flow?
and the srtool
ONLY performs srtool build.
show only info of compressed-wasm
b-yap
force-pushed
the
task-170-automate-runtime-release-process
branch
from
02e822a
to
4d61a1a
Compare
b-yap
changed the title
|
All the scripts have been moved to gitlab. |
b-yap
changed the title
Yes, I'll leave that to Zoltan; I've already moved the scripts to gitlab. And the process should be easier over there, than this github CI. |
|
I also checked the Gitlab code now and it all looks good to me. Let's merge this now or is there a reason not to do that yet @b-yap? |
|
@ebma, I "resolved" the conversations but the |
|
@b-yap should work now, at least it's all green for me. |
partially closes https://github.com/pendulum-chain/tasks/issues/170.
added a script for picking commits related to specific runtime;added a github action for srtool (based on bifrost's)added a js for authorizing upgrade based on the srtool.Full info can be found in the issue.