Fix failing tests for invalid control characters in comments #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning comments, it makes better sense to halt scanning and immediately return if an illegal character is encountered while scanning. This can save on performance in the perverse case of an extremely long comment that has an early offending character. Related to: pelletier#613
Partially resolves: pelletier#613
Partially resolves: pelletier#613
Previously, the generated tests from toml-test were not failing when expected for NUL and US control characters. Using the Unicode values for these tests instead of the \xNN notation corrected this failure. Related to: pelletier#613
Partially resolves: pelletier#613
Partially resolves: pelletier#613
jidicula
force-pushed
the
ji/issue-613-comment-invalid-control
branch
from
1c407d1 to
bd5442e
Compare
|
I've offered up a competing PR in #620 that would supersede this offering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #613
scanComment()to error out early if an illegal character is foundscanComment()Note that the NUL and US control characters weren't causing tests to fail prior to me making my changes... I took a quick look into why but couldn't crack why those tests weren't failing on my machine (Turns out the codegen used the xNN notation instead of Unicode values for NUL and US control characters. I've modified the testgen file accordingly.TestTOMLTest_Invalid_Control_CommentNullandTestTOMLTest_Invalid_Control_CommentUs).