Encode: make floats always contain a decimal point #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #571
This is a fix to the integer to float conversion mentioned in #571.
This is breaking a test that seems to be ensuring that the existing behavior is preserved, so it's not ready for a merge. I didn't really know what to make of what this was testing, so if you'll let me know what this test is supposed to accomplish or how to correct it I will.
Also, I looked into adding support for unmarshalling into
complex64
andcomplex128
, but since you can't marshal those, that seemed a bit pointless. As far as I can tell, this is the only integer conversion missing. I suspect the reverse conversion is not a problem, but I did not look into it.