tomltestgen: add toml-test unit test generation command #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are hidden behind a "testsuite" build tag for now since many tests are failing. Use `go test -tags testsuite` to activate. Use `go generate` to regenerate toml_testgen_test.go.
|
Looking good! Do you have plans to import Good idea to make it work with |
|
Yes, I have a cmd package for the toml-test binary interface which will use this package. We could move the generated test file (and support file) into the testsuite package and avoid exporting some functions, but I was trying to work with the existing files. |
|
👍🏻 Sounds good. Merging this and will create a follow up issue to fix failing tests. Edit: #613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomltestgento v2.toml-testfile layout changed recently, so updated to work with sub-folders.toml_testgen_support_test.go.Issue: #599