Decode: ensure signed exponents don't start with an underscore (#699)

pelletier · Dec 6, 2021 · 8bbb519 · 8bbb519
1 parent b37e11d
commit 8bbb519
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/decode.go b/decode.go
@@ -465,6 +465,10 @@ func checkAndRemoveUnderscoresFloats(b []byte) ([]byte, error) {
 				return nil, newDecodeError(b[i+1:i+2], "cannot have underscore before exponent")
 			}
 			before = false
+		case '+', '-':
+			// signed exponents
+			cleaned = append(cleaned, c)
+			before = false
 		case 'e', 'E':
 			if i < len(b)-1 && b[i+1] == '_' {
 				return nil, newDecodeError(b[i+1:i+2], "cannot have underscore after exponent")

diff --git a/unmarshaler_test.go b/unmarshaler_test.go
@@ -2317,6 +2317,14 @@ func TestUnmarshalDecodeErrors(t *testing.T) {
 			desc: "number with negative sign and leading underscore",
 			data: `a = -_0`,
 		},
+		{
+			desc: "exponent with plus sign and leading underscore",
+			data: `a = 0e+_0`,
+		},
+		{
+			desc: "exponent with negative sign and leading underscore",
+			data: `a = 0e-_0`,
+		},
 		{
 			desc: "int with wrong base",
 			data: `a = 0f2`,